Reuse the same DistributedContext more often. #13221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does it mean, not executing "startup" as many times? Making one execution "faster", what is an "execution" ? |
It prevents some shell container building and for some temporary containers reduce the number of features involved, so reduce the number of startup Another goal is related to #13169 where we allow to regiter async service initializations (through the startup infrastructure) when a shell container is built, so it would also reduce the number of times these initializations are executed. |
jtkech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
DistributedShellHostedServiceto keep tenants in sync we create an isolated context based on the Default shell. One use case is when the Default context is aShellContext.PlaceHolderand then replaced by a fullShellContext, even if nothing has changed, only because the shell is lazily built on demand, before the isolated shell was always rebuilt, here we prevent this if nothing has changed.Also, in
ShellContextFactorywhen creating a temporary context and scope to retrieve the current descriptor, here we use an emptyShellDescriptor, this because the resolution ofIShellDescriptorManagerdoesn't depend on a feature but on an explicit registration. The result is that when building this temporary context less startupConfigureServices()are called.Related to #13169 where we allow to register startup async initializations, so reducing startup executions will also reduce these async initializations.